-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install and use of Jupyter Kernel for docs #845
Conversation
Pull Request Test Coverage Report for Build 4496904050
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this for real, my eager pinning wasn't sufficient. I'm a bit surprised that we need to manually install ipykernel I'm guessing it was getting pulled in transitively by something before and a package was missing it in its requirements list. But since this is passing CI it should be good to go.
@@ -9,3 +9,4 @@ qiskit-sphinx-theme>=1.7 | |||
matplotlib>=3.4 | |||
sphinx-reredirects | |||
sphinxemoji | |||
ipykernel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite surprised this isn't getting pulled in anymore. I would expect jupyter-sphinx to end up pulling this in.
Tries to fix the same problem as #844 but without pinning
For some reason the
python3
kernel stopped being installed togethe with Jupyter, hence: